Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add user preference combobox for BSQ block explorer with random default #3792

Merged
merged 3 commits into from
Dec 18, 2019
Merged

Add user preference combobox for BSQ block explorer with random default #3792

merged 3 commits into from
Dec 18, 2019

Conversation

wiz
Copy link
Contributor

@wiz wiz commented Dec 15, 2019 •
edited
Loading

Screen Shot 2019-12-16 at 0 21 25

Implements bisq-network/proposals#143

Needs review and testing

@wiz wiz requested review from ripcurlx and sqrrm as code owners December 15, 2019 15:20
@wiz wiz mentioned this pull request Dec 15, 2019
Closed
chimp1984
chimp1984 previously approved these changes Dec 15, 2019
View reviewed changes
Copy link
Contributor

@chimp1984 chimp1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

IMO betanet and testnet can be removed...

core/src/main/java/bisq/core/user/Preferences.java Outdated Show resolved Hide resolved
core/src/main/java/bisq/core/user/Preferences.java Outdated Show resolved Hide resolved
ripcurlx
ripcurlx suggested changes Dec 17, 2019
View reviewed changes
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK - please see the comments from @chimp1984 and myself.

core/src/main/java/bisq/core/user/Preferences.java Outdated Show resolved Hide resolved
@wiz wiz requested a review from ripcurlx December 17, 2019 10:42
sqrrm
sqrrm previously approved these changes Dec 17, 2019
View reviewed changes
Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx added this to the v1.2.5 milestone Dec 18, 2019
ripcurlx
ripcurlx approved these changes Dec 18, 2019
View reviewed changes
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Tested it on Mainnet and everything works as expected for @wiz explorer. @sqrrm explorer should be available for our v1.2.5 release

@ripcurlx ripcurlx merged commit 2782e58 into bisq-network:master Dec 18, 2019
@wiz wiz deleted the add-bsq-explorer-combobox branch December 18, 2019 07:56
@wiz wiz mentioned this pull request Dec 18, 2019
Merged
@ripcurlx ripcurlx mentioned this pull request Jan 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ripcurlx ripcurlx ripcurlx approved these changes

@chimp1984 chimp1984 chimp1984 left review comments

@sqrrm sqrrm sqrrm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2.5
Development

Successfully merging this pull request may close these issues.
4 participants
@wiz @ripcurlx @sqrrm @chimp1984